Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tiup no-sudo doc #20179

Merged
merged 20 commits into from
Feb 19, 2025
Merged

add tiup no-sudo doc #20179

merged 20 commits into from
Feb 19, 2025
+215 −0

Conversation

Yujie-Xie
Copy link

@Yujie-Xie Yujie-Xie commented Feb 6, 2025 •
edited by hfxsd
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Feb 6, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 6, 2025

Hi @Yujie-Xie. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 6, 2025
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Feb 7, 2025
@hfxsd hfxsd self-assigned this Feb 7, 2025
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Feb 10, 2025
@hfxsd hfxsd mentioned this pull request Feb 10, 2025
Merged
16 tasks
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 10, 2025

@kaaaaaaang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added needs-cherry-pick-master Should cherry pick this PR to master branch. and removed needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Feb 10, 2025
@hfxsd hfxsd closed this Feb 10, 2025
@hfxsd hfxsd reopened this Feb 10, 2025
lilin90
lilin90 reviewed Feb 18, 2025
View reviewed changes
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated
source ~/.bashrc.d/systemd
```

2. Use `root` user to start user service.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Use `root` user to start user service.
2. Use the `root` user to start the user service.

tiup/tiup-cluster-no-sudo-mode.md Outdated
└─3358 /usr/bin/pulseaudio --daemonize=no --log-target=journal
```

Execute `systemctl --user` in the terminal. If no errors are reported, it indicates that it has started normally.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Execute `systemctl --user` in the terminal. If no errors are reported, it indicates that it has started normally.
3. Execute `systemctl --user`. If no errors occur, it indicates that the `systemd user` mode has started successfully.

tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Feb 19, 2025
View reviewed changes
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
@Yujie-Xie @lilin90 @hfxsd
Apply suggestions from code review
3b5bd98 
Co-authored-by: Lilian Lee <[email protected]>
Co-authored-by: xixirangrang <[email protected]>
lilin90
lilin90 reviewed Feb 19, 2025
View reviewed changes
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
tiup/tiup-cluster-no-sudo-mode.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 19, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 19, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-19 08:08:16.763575855 +0000 UTC m=+1035139.159797910: ☑️ agreed by lilin90.
  • 2025-02-19 08:12:59.150365139 +0000 UTC m=+1035421.546587213: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Collaborator

hfxsd commented Feb 19, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 19, 2025
@ti-chi-bot ti-chi-bot bot merged commit eed4bdd into pingcap:release-8.1 Feb 19, 2025
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch master: #20320.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 19, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20321.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 19, 2025
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Feb 19, 2025
@ti-chi-bot
add tiup no-sudo doc (#20179) (#20321)
cfc4f28
@hfxsd hfxsd added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. and removed needs-cherry-pick-master Should cherry pick this PR to master branch. labels Feb 19, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: base branch (release-8.1) needs to differ from target branch (release-8.1).

ti-chi-bot bot pushed a commit that referenced this pull request Feb 19, 2025
@ti-chi-bot
add tiup no-sudo doc (#20179) (#20320)
922618c
This was referenced Feb 19, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@hfxsd hfxsd hfxsd approved these changes

@kaaaaaaang kaaaaaaang kaaaaaaang approved these changes

Assignees

@hfxsd hfxsd

Labels
approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yujie-Xie @hfxsd @ti-chi-bot @lilin90 @kaaaaaaang